Improve handling of Anaconda hanging #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
changed the title
When monitoring log output in livemedia-creator --no-virt it could get stuck if the output from anaconda stops for some reason. This changes execReadlines so that it will only read output when it is available, will monitor the process state, and continue to call the callback function. It also adds a final timeout on proc.communicate() so that if Anaconda becomes stuck and won't exit livemedia-creator will eventually exit. When the no-virt callback terminates anaconda on an error it now sends a TERM signal to all of the unshare process' children because just sending it to unshare doesn't cause anaconda to exit.
This will cause livemedia-creator to terminate anaconda and exit when an install hits an error that often causes anaconda to get stuck and not exit. Resolves: rhbz#1900596
The libgomp bug rhbz#1722181 has been closed since August.
Pull Request Test Coverage Report for Build 424372319
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.