Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of Anaconda hanging #1101

Merged
merged 3 commits into from Dec 16, 2020
Merged

Improve handling of Anaconda hanging #1101

merged 3 commits into from Dec 16, 2020

Commits on Dec 15, 2020

  1. Improve lmc no-virt error handling 

    When monitoring log output in livemedia-creator --no-virt it could get
stuck if the output from anaconda stops for some reason.

This changes execReadlines so that it will only read output when it is
available, will monitor the process state, and continue to call the
callback function.

It also adds a final timeout on proc.communicate() so that if Anaconda
becomes stuck and won't exit livemedia-creator will eventually exit.

When the no-virt callback terminates anaconda on an error it now sends a
TERM signal to all of the unshare process' children because just sending
it to unshare doesn't cause anaconda to exit.
    @bcl
    bcl committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    6400515 View commit details
    Browse the repository at this point in the history

  2. Add POSTIN scriptlet error to the log monitor list 

    This will cause livemedia-creator to terminate anaconda and exit when an
install hits an error that often causes anaconda to get stuck and not
exit.

Resolves: rhbz#1900596
    @bcl
    bcl committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    a33efe7 View commit details
    Browse the repository at this point in the history

  3. Remove LD_PRELOAD libgomp.so.1 from lmc --no-virt 

    The libgomp bug rhbz#1722181 has been closed since August.
    @bcl
    bcl committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    b0318ef View commit details
    Browse the repository at this point in the history