Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firmware cleanups 20220509 #1229

Merged
merged 4 commits into from
May 17, 2022
Merged

Conversation

AdamWill
Copy link
Contributor

Several additional firmware file trims to save back space lost with upstream 20220509 firmware release. This saves 11M in my local testing, nearly all of the 13M that we lost with the update.

Per the WHENCE file, these go along with sdm845 and sm8250 which
we strip already.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
These are the same as qcom/venus* which we strip already, video
codec accelerator firmwares - they just changed the name from
venus to vpu along the way.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Recent linux-firmware versions include some lc_ini_bundle* files
as well as mlxsw_spectrum*, they all seem to be part of the same
thing.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This is another specialist enterprise NIC firmware, for the
"NetXen Multi port (1/10) Gigabit Ethernet NIC".

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2341746059

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.538%

Totals Coverage Status
Change from base Build 2309159816: 0.0%
Covered Lines: 1376
Relevant Lines: 2920

💛 - Coveralls

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the excellent commit messages!

@bcl bcl merged commit 07d821f into weldr:master May 17, 2022
Copy link
Contributor

@nullr0ute nullr0ute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're probably better off just removing all of the mellanox directory rather than removing random bits, unless you can explicitly test you may well end up with devices in weird states if parts of firmware are missing. All or nothing is likely a better experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants