Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-install: drop kdump-anaconda-addon #1349

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

AdamWill
Copy link
Contributor

I'm proposing making this part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct.

Do not merge this until rhinstaller/anaconda#5205 is merged. This is not at all urgent.

@coveralls
Copy link

coveralls commented Sep 25, 2023

Pull Request Test Coverage Report for Build 7744917563

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.339%

Totals Coverage Status
Change from base Build 7744857571: 0.0%
Covered Lines: 1608
Relevant Lines: 3496

💛 - Coveralls

@AdamWill
Copy link
Contributor Author

the anaconda PR is merged now, but we still shouldn't merge this till an anaconda build with the change is stable in rawhide, I think.

@VladimirSlavik
Copy link
Contributor

VladimirSlavik commented Sep 28, 2023

Agreed. [Anaconda] Rawhide builds happen each Tuesday morning, so hopefully Wesnesday will be the day to move forward with this.

@AdamWill AdamWill changed the title **DO NOT MERGE YET** runtime-install: drop kdump-anaconda-addon runtime-install: drop kdump-anaconda-addon Feb 1, 2024
I'm proposing making this part of anaconda-install-env-deps
instead in rhinstaller/anaconda#5205 .
It's more correct.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack ack

@bcl bcl merged commit a88fcaf into weldr:master Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants