install-env-deps: recommend kdump-anaconda-addon #5205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamWill
added a commit
to AdamWill/lorax
that referenced
this pull request
Sep 25, 2023
I'm proposing making this part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Corresponding lorax and comps PRs - weldr/lorax#1349 and https://pagure.io/fedora-comps/pull-request/898 . |
|
Thanks! Makes sense. You want to Recommend this in -env- and Require in -img-, that's the pattern we followed so far. |
Way back in https://bugzilla.redhat.com/show_bug.cgi?id=1115914 and https://bugzilla.redhat.com/show_bug.cgi?id=1176483 , we wanted to get this addon included in the install environment. However, it wasn't really done properly. As things wound up, it got listed in lorax runtime-install.tmpl (which does the job of getting it in the 'traditional' installer environment, but not getting it on live images), and then to get it on live images, it was added to the anaconda-tools comps group. This got the job done, but isn't correct. anaconda-tools is meant to contain packages that the installer might need to deploy to the installed system, not packages that should be in the installer environment. It only wound up getting the package installed in the live environment because we have to include all packages from anaconda-tools in the lives because we have no way to add packages to live installs at install time. Adding this here is more correct, and would mean we only need to list it in one place (here) instead of two (lorax templates and comps). Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
force-pushed
the
recommend-kdump-addon
branch
from
88b1efd
to
b91b606
Compare
VladimirSlavik
approved these changes
Sep 26, 2023
|
/kickstart-test --testtype smoke |
M4rtinK
approved these changes
Sep 27, 2023
AdamWill
added a commit
to AdamWill/lorax
that referenced
this pull request
Feb 1, 2024
I'm proposing making this part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct. Signed-off-by: Adam Williamson <awilliam@redhat.com>
bcl
pushed a commit
to weldr/lorax
that referenced
this pull request
Feb 1, 2024
I'm proposing making this part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct. Signed-off-by: Adam Williamson <awilliam@redhat.com>
bcl
pushed a commit
to bcl/lorax
that referenced
this pull request
Mar 28, 2024
I'm proposing making this part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct. Signed-off-by: Adam Williamson <awilliam@redhat.com>
U2FsdGVkX1
pushed a commit
to fedora-riscv/fedora-comps
that referenced
this pull request
Apr 4, 2024
I'm proposing making the addon part of anaconda-install-env-deps instead in rhinstaller/anaconda#5205 . It's more correct. This group is meant to contain things that may be needed *on the installed system*, not in the installer environment. The addon is needed in the installer environment, not the installed system. However, one thing the addon does is add kexec-tools to the list of packages to be installed to the installed system, so we should add kexec-tools to this group for correctness. Signed-off-by: Adam Williamson <awilliam@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in https://bugzilla.redhat.com/show_bug.cgi?id=1115914 and https://bugzilla.redhat.com/show_bug.cgi?id=1176483 , we wanted to get this addon included in the install environment. However, it wasn't really done properly. As things wound up, it got listed in lorax runtime-install.tmpl (which does the job of getting it in the 'traditional' installer environment, but not getting it on live images), and then to get it on live images, it was added to the anaconda-tools comps group.
This got the job done, but isn't correct. anaconda-tools is meant to contain packages that the installer might need to deploy to the installed system, not packages that should be in the installer environment. It only wound up getting the package installed in the live environment because we have to include all packages from anaconda-tools in the lives because we have no way to add packages to live installs at install time.
Adding this here is more correct, and would mean we only need to list it in one place (here) instead of two (lorax templates and comps).