Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path to generic.prm #728

Closed
wants to merge 1 commit into from
Closed

Fix path to generic.prm #728

wants to merge 1 commit into from

Conversation

jstodola
Copy link
Contributor

Also quote ${extra_boot_args} as in the other templates

Resolves: rhbz#1712822

--- Description of proposed changes ---

--- Merge policy ---

  • Travis CI PASS
  • *-aws-runtest PASS
  • *-azure-runtest PASS
  • *-images-runtest PASS
  • *-openstack-runtest PASS
  • *-vmware-runtest PASS
  • For rhel8-* and rhel7-* branches commit log references an approved
    bug in Bugzilla. Do not merge if the bug doesn't have the 3 ACKs set to +!

--- Jenkins commands ---

  • ok to test to accept this pull request for testing
  • test this please for a one time test run
  • retest this please to start a new build

@jstodola
Fix path to generic.prm
7d2105a 
Also quote ${extra_boot_args} as in the other templates

Resolves: rhbz#1712822
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1642

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.993%
Totals Coverage Status
Change from base Build 1616: 0.0%
Covered Lines: 2555
Relevant Lines: 4891
💛 - Coveralls

@atodorov atodorov requested a review from bcl May 23, 2019 08:03
atodorov
atodorov approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bcl I can't quite understand if the referenced Bug is approved or not. Feel free to merge at will.

bcl
bcl approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@bcl
Copy link
Contributor

bcl commented Jun 4, 2019

Merged to rhel8-branch and rhel8.0-branch

@bcl bcl closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcl bcl bcl approved these changes

@atodorov atodorov atodorov approved these changes

Assignees
No one assigned
Labels
rhel8-branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jstodola @coveralls @bcl @atodorov