lorax: Drop unused --title option #881

bcl · 2019-10-18T18:17:04Z

It has never been hooked up to anything, let alone substitution @title@
(which also hasn't ever been used in the config files).

Closes #863

coveralls · 2019-10-18T18:33:11Z

Pull Request Test Coverage Report for Build 2223

0 of 0 changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 57.436%

Files with Coverage Reduction	New Missed Lines	%
src/pylorax/api/queue.py	3	57.55%

Totals
Change from base Build 2217:	-0.04%
Covered Lines:	4178
Relevant Lines:	7090

💛 - Coveralls

chris1984

ACK

@title

It has never been hooked up to anything, let alone substitution @title@ (which also hasn't ever been used in the config files). Closes weldr#863

chris1984 previously approved these changes Oct 18, 2019

View reviewed changes

lorax: Drop unused --title option

af3494f

It has never been hooked up to anything, let alone substitution @title@ (which also hasn't ever been used in the config files). Closes weldr#863

bcl dismissed chris1984’s stale review via af3494f October 25, 2019 18:35

bcl force-pushed the master-pr863 branch from 1ef3c2c to af3494f Compare October 25, 2019 18:35

bcl merged commit af3494f into weldr:master Oct 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lorax: Drop unused --title option #881

lorax: Drop unused --title option #881

bcl commented Oct 18, 2019

coveralls commented Oct 18, 2019

chris1984 left a comment

lorax: Drop unused --title option #881

lorax: Drop unused --title option #881

Conversation

bcl commented Oct 18, 2019

coveralls commented Oct 18, 2019

Pull Request Test Coverage Report for Build 2223

💛 - Coveralls

chris1984 left a comment

Choose a reason for hiding this comment