Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be possible to have storeKeys both in a widget definition and in it's editable parameters #223

Closed
wellenvogel opened this issue May 19, 2022 · 2 comments
Closed

It should be possible to have storeKeys both in a widget definition and in it's editable parameters #223

wellenvogel opened this issue May 19, 2022 · 2 comments
Labels
bug

Comments

@wellenvogel
Copy link
Owner

Currently when there are storeKeys in a widget's editable parameters (like the "value" parameter for the default widget) any storeKeys directly defined at the widget definition are ignored.
This is at least surprising as all other parameters are simply merged.
So there should also be a merge for the store keys
wellenvogel pushed a commit that referenced this issue May 19, 2022
#223: correctly merge storeKeys from a widget definition and from it'…
942a4a1 
…s editable parameters
@PietKnot
Copy link

PietKnot commented Jun 5, 2022

you may close this issue, i guess as i can't grasp the technical description. No problem anymore with WPD-widget: working as expected.

@wellenvogel
Copy link
Owner Author

20220819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wellenvogel @PietKnot