Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When target doesn't exist, no error, and command is put into undo history #4

Closed
jsit opened this issue Feb 7, 2014 · 3 comments · Fixed by #10
Closed

When target doesn't exist, no error, and command is put into undo history #4

jsit opened this issue Feb 7, 2014 · 3 comments · Fixed by #10

Comments

@jsit
Copy link

jsit commented Feb 7, 2014

Say I have this line, because I just installed targets.vim and am playing:

asdf;asdf;asdf;asdf;asdf;asdf;asdf;asdf;asdf;asdf;asdf

With my cursor somewhere in that line, I start typing da; over and over again until I end up with this:

asdf;asdf

Pressing da; again doesn't do anything, of course, because there is only one semicolon left. But there is no error, and the command is entered into the undo history. For instance, if at this point I (ineffectively) hit da; three times, I have to hit u three times to "actually start undoing" and get my text back to where it was before the last successful da;.

@wellle
Copy link
Owner

wellle commented Feb 7, 2014

You are right, it should not be put into the undo history. I will have to look into it and see how to avoid that.

I wouldn't say that there should be an error message though. Stock Vim doesn't complain about missing text objects either.

@jsit
Copy link
Author

jsit commented Feb 7, 2014

If not a message, then at least a bell (which I do hear for missing standard text objects).

On Fri, Feb 7, 2014 at 11:19 AM, Christian Wellenbrock <
notifications@github.com> wrote:

You are right, it should not be put into the undo history. I will have to
look into it and see how to avoid that.

I wouldn't say that there should be an error message though. Stock Vim
doesn't complain about missing text objects either.

Reply to this email directly or view it on GitHubhttps://github.com//issues/4#issuecomment-34460385
.

@wellle
Copy link
Owner

wellle commented Feb 7, 2014

Oh that's a good point. I have turned the bell off in my terminal, that's why I didn't notice. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants