Caddy v2 #1205
Merged
Caddy v2 #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Jun 26, 2020
damienallen
force-pushed
the
feature/caddy2
branch
from
f9e9713
to
18ec8ad
Compare
sobolevn
approved these changes
Jun 28, 2020
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
Here's the caddy v2 setup. I tried to match the existing configuration as much as possible.
However, I got caught up for a while on two different issues that we blocking (even for the unmodified master branch) and slowed me down quite a lot:
My poetry environment was unable to find "typing_extensions" in server/apps/main/models.py:5 unless I specifically added the dependency. However, it looks like
finalandFinalwill be included in the Python 3.8 standard library so I assume it will be a non-issue after moving to 3.8.Both the django-media and django-static volumes were mounted as root:root with 755 permissions inside the web container, thus collectstatic would throw a permission errors. I think it was related to this issue.
I changed pyproject.toml and ./docker/django/Dockerfile to fix these but I could be missing something...