Add instructions on how to run the tests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally agree, thanks! |
sobolevn
added a commit
that referenced
this pull request
Mar 6, 2020
* Add ExecutableMismatchViolation #9 * Add logic for ExecutableMismatch * Add WPS452 to test_noqa.py #5 * Remove dependency and related test * Implement the full checking logic (#13) * Fix linting problem (#14) * Clean up code (#15) Fix checking logic so that we don't thoroughly check every comment * Fix permissions (#16) * Make a new visitor to handle files with 0 comments (#17) * Add tests for ExecutableMismatchViolation (#18) * Add ExecutableMismatchViolation #9 * Add WPS452 to test_noqa.py #5 * Remove dependency and related test * Add test resource files from flake8-executable * Add tests for check_valid_shebang #7 * Implement the full checking logic (#13) * Fix linting problem (#14) * Clean up code (#15) Fix checking logic so that we don't thoroughly check every comment * Fix permissions (#16) * Ignore failing test files * Update test file to be compatible with the new visitor * Fix linter issues * Make a new visitor to handle files with 0 comments (#17) * Exclude test files from linting Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com> Co-authored-by: jrutqvist <joar.rutqvist@gmail.com> Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com> * Update CHANGELOG.md * Moved test resources to fixtures to be ignored by autopep8 * Add integration test * Refactor tests * Make the requested changes Use temporary files for testing * Update noqa.py * Make additional requested changes * Fix small formatting and typing issues * Update comments.py * Update comments.py Co-authored-by: hanzhsu <emily_1999@link.cuhk.edu.hk> Co-authored-by: Gabriel Chang <Gc.chang95@gmail.com> Co-authored-by: Hanzhang <48179160+hanzhsun@users.noreply.github.com> Co-authored-by: jrutqvist <joar.rutqvist@gmail.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make life easier for the new contributors, I decided to add the instructions on how to run the tests for the plugin.
Please correct me if they are wrong.