Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValueError on input arrays of length 0 #4

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Raise ValueError on input arrays of length 0 #4

merged 1 commit into from
Mar 28, 2019

Conversation

geier
Copy link
Contributor

@geier geier commented Jan 4, 2019

Input of length zero used to seg fault SuperCluster.

@jlaine
Copy link
Contributor

jlaine commented Mar 27, 2019

Hi!

Could you please provide a unit test for this?

Jeremy

@geier
Raise ValueError on input arrays of length 0
ff0d93c 
Input of length zero used to seg fault SuperCluster.
@geier
Copy link
Contributor Author

geier commented Mar 28, 2019

Good point, sorry about that.

@geier
Copy link
Contributor Author

geier commented Mar 28, 2019

Turns out, I already had a test, just forgot to include it in the commit :( Should be included now.

@jlaine jlaine merged commit 1cb2440 into wemap:master Mar 28, 2019
@jlaine
Copy link
Contributor

jlaine commented Mar 28, 2019

Thanks you Christian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geier @jlaine