Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to docs page build #212

Merged
merged 9 commits into from
Nov 8, 2017
Merged

Conversation

wende
Copy link
Owner

@wende wende commented Oct 15, 2017

Continuation of #210 due to problems with the website:

  • Page is too wide
  • Top menu isn't center aligned with the rest of the page
  • Elchemy-core changes that shouldn't be there

CC @baransu

@wende
Copy link
Owner Author

wende commented Nov 2, 2017

@baransu bump

@baransu
Copy link
Collaborator

baransu commented Nov 2, 2017

I haven't had time to look into it and I won't have time until next weekend unfortunately. 😞

@baransu
Copy link
Collaborator

baransu commented Nov 8, 2017

I'm not 100% sure how git submodules work but I've checkout elchemy-core to current commit that we're using on master branch of elchemy.

@wende
Copy link
Owner Author

wende commented Nov 8, 2017

@baransu after updating the branch to master it should be desired behaviour then (no changes to core)

@wende
Copy link
Owner Author

wende commented Nov 8, 2017

The main cause of reverting this PR was the page width which causes horizontal scroll and was significantly impairing the experience on mobile devices

@baransu
Copy link
Collaborator

baransu commented Nov 8, 2017

The width is fixed.

What do you thing about adding make build-page to release rule so docs page will be always up to date with the latest release?

@wende
Copy link
Owner Author

wende commented Nov 8, 2017

@baransu sounds good. I would add it right after make release in ./bump.sh then

@wende wende merged commit c100e14 into master Nov 8, 2017
@wende wende deleted the improvements-to-docs-page-build branch November 8, 2017 13:55
wende added a commit that referenced this pull request Nov 8, 2017
================

  * Improvements to docs page build (#212)
  * Fixes to ISSUE TEMPLATE inspired by #218
  * stable version online too
  * better release
  * Update README.md
  * Update README.md
  * Update README.md
  * Update ISSUE_TEMPLATE
  * Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants