stdlib: Improve sin, cos and tan (*/1/3) #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robust: ^/4 (Does it work for all input values?) Accurate: 1/4 (How accurate is the result?) Well behaved: 3/4 (Does it preserve math properties?) ^ They technically work for all input values. But for very large input, the loss of accuracy makes them practically useless. The result could be severely inaccurate either when the angle is very large, or when the angle is very close to a multiple of pi/2.
|
Great, thanks! These math are starting to get too complex for me to comprehend, but I'm going to trust you since you seem to be very good at it :) @antfu I'm wondering if you could please merge & update the tests? They're probably failing because the results are (hopefully) more accurate. I recall that the floating point results are different on different OS's, hence updating tests on my laptop will probably fail Github? Thanks! |
|
Sure. I will have a look tomorrow and probably trying to find out a way to solve the floating number output precision problem. Happy New Year btw! |
|
The failing test is |
|
thanks and happy new year everyone |
LingDong-
added a commit
that referenced
this pull request
Jan 20, 2020
stdlib: Improve sin, cos and tan (*/1/3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Robust: 2*/4 (Does it work for all input values?)
Accurate: 1/4 (How accurate is the result?)
Well behaved: 3/4 (Does it preserve math properties?)
* They technically work for all input values. But for very large input, the loss of accuracy makes them practically useless.
The result could be severely inaccurate either when the angle is very large, or when the angle is very close to a multiple of pi/2.