feat: support for 序.wy and 藏書樓 in cli #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍, thanks! |
|
@LingDong- Can I make a release for this? 😏 |
|
Sure! |
LingDong-
added a commit
that referenced
this pull request
Jan 20, 2020
feat: support for 序.wy and 藏書樓 in cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a more flexible import mechanism for 3-rd party libraries and package management. #510 #100 #154
The reader now will search for a module '四庫全書' for a given path '/tmp/examples'
/tmp/examples/四庫全書.wy/tmp/examples/四庫全書/序.wyThe first match will be imported.
Heretical import is NOT implemented yet. For example
When
四庫全書/序.wyimports本草綱目will search for/tmp/examples/四庫全書/本草綱目.wy/tmp/examples/四庫全書/本草綱目/序.wyTo archive this, we need to the current file path to manipulate the
importPathsand this may require some refactoring to current codebase. So I will make another PR for that later.藏書樓asnode_moduleswill be included asimportPathsby CLI automatically. It will do an up searching for藏書樓from the cwd (just as node did)