Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs related to Filter-Control #5129

Merged
merged 17 commits into from
Jul 8, 2020
Merged

Conversation

djhvscf
Copy link
Collaborator

@djhvscf djhvscf commented Jun 27, 2020

WORK IN PROGRESS

Bug fix?
yes

New Feature?
no

Resolve an issue?
Fix #4869
Fix #5045

Example(s)?
https://live.bootstrap-table.com/code/djhvscf/3819

@djhvscf
Copy link
Collaborator Author

djhvscf commented Jun 27, 2020

image

@djhvscf djhvscf changed the title Moving functions to utils files WIP - Moving functions to utils files Jun 27, 2020
@djhvscf djhvscf changed the title WIP - Moving functions to utils files WIP - Fix bugs related to Filter-Control Jun 27, 2020
@UtechtDustin
Copy link
Collaborator

@djhvscf You requested a review, but there are no examples and the titles says work in progress :D

@djhvscf
Copy link
Collaborator Author

djhvscf commented Jul 6, 2020

@djhvscf You requested a review, but there are no examples and the titles says work in progress :D

Yes sorry.. I requested that by mistake. I will let you know when this is available

@djhvscf djhvscf changed the title WIP - Fix bugs related to Filter-Control Fix bugs related to Filter-Control Jul 6, 2020
@wenzhixin
Copy link
Owner

Updated the code, but I find an error: https://live.bootstrap-table.com/code/wenzhixin/3818

const value = _value.trim()

When the _value is 0 will cause an error, please check this @djhvscf .

@djhvscf
Copy link
Collaborator Author

djhvscf commented Jul 8, 2020

Updated the code, but I find an error: https://live.bootstrap-table.com/code/wenzhixin/3818

const value = _value.trim()

When the _value is 0 will cause an error, please check this @djhvscf .

Resolved: https://live.bootstrap-table.com/code/djhvscf/3819 @wenzhixin

@wenzhixin wenzhixin merged commit a74a8d7 into develop Jul 8, 2020
@wenzhixin wenzhixin deleted the feature/separate-files branch July 8, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants