-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple select in filter-control #3298
Comments
Hello |
Consider adding support for https://github.com/wenzhixin/multiple-select plugin. |
https://live.bootstrap-table.com/code/sebastiangehrt/2413 is the correct use case for multi select for e.g. a categorie |
@wenzhixin multiple-select.js plugin does not seem to work together with bootstrap-table-filter-control.js see https://codepen.io/rayzoray/pen/pojooVo |
@wenzhixin no not exactly: data-field="city" must be class="multiple-select". |
You can use the bootstrap theme: http://multiple-select.wenzhixin.net.cn/examples#themes.html |
@wenzhixin theme helps, but selecting checkbox options does not filter table; see example pen: https://codepen.io/rayzoray/pen/jObOdvz |
Yes, multiple select filtering is not yet supported, so mark it as a feature. |
@wenzhixin do you have a temporary solution or workaround that you can share for this feature? as this issue has been identified in 2017? |
Just to update the case: https://live.bootstrap-table.com/code/albfan/3509 I think some work needs to be done on filtering multiple select (like do a OR instead of AND filter), but that's expected. @wenzhixin so just using the dist/ directory instead of cdn is enough right? |
@albfan |
Hi guys. Any news on this? |
Still working on it. This requires the extension to be rewritten. |
Hi :) any rough guess, when this feature will be added? |
Hi guys, this would really be a nice functionality. |
@djhvscf any update on when this feature may be available? Let me know if I can be of any assistance. |
hi, I'm working on recreate the extension. This in order to have a better extension, robust and stable. See the progress here: https://github.com/wenzhixin/bootstrap-table/tree/feature/multiselect-filtercontrol |
@djhvscf Any running example. I try modifying my old one with your branch, but nothing seems to work |
See this PR #5583 |
I tried to follow PR but can see how to enable multiselect. I expected something like Is there anything we can check using that PR @djhvscf? |
@UtechtDustin of course. In the mean time I just update the example to use multiple-select. https://live.bootstrap-table.com/code/albfan/7140 NOTE: at onCreatedControls options are still not loaded |
Example reworked to use multiselect with filterBy: It honor cleanSearch: https://live.bootstrap-table.com/code/albfan/7162 multiselect-bootstrap-table.mp4 |
We're going to implement multiselect using this library http://multiple-select.wenzhixin.net.cn/ which is part of @wenzhixin work! |
@djhvscf there's a mistake in docs, it is not After fix, multiselect is working as expected. Will create a PR targetting your PR to fix that part. Will do the same for |
@albfan |
This feature is removed from the current scope of #5583 |
Hi all, I am looking for exactly this feature; using the Multiple Select widget in a column filter would be perfect. @djhvscf (or others!): Given that you tried this but then removed it from the scope of #5583, might you have either warnings or tips on how to implement this? Perhaps you have any (incomplete) code/branch that I could try to continue with, instead of starting from scratch? |
@gb-noyb we need to start from scratch since this is a major feature for this extension. But since the performance is the priority right now, we don't have plans to implement this feature in the near future |
I reworked the live example to use @djhvscf and my improvements (based on 1.18.3 version): https://github.com/albfan/bootstrap-table/tree/feature/multiselect-filtercontrol See this only works in bootstrap 4: https://live.bootstrap-table.com/code/albfan/12640 @wenzhixin @djhvscf I can work on this if we describe the problems detected (even if that's from scratch) |
@albfan let's work on that. What kind of details do you need? |
cool @djhvscf. My understanding is from:
Some major problems where detected and the feature was rejected.
I have this https://github.com/albfan/bootstrap-table/tree/feature/multiselect-filtercontrol, but something on upstream would be better. Not sure if it is ok to have another feature branch (looks bootstrap table always work on develop branch until merge to master and tag)
https://live.bootstrap-table.com/code/albfan/12674 which is super clean and works with multiple, non multiple selects, inputs. It uses Detected problems:
https://live.bootstrap-table.com/code/albfan/12676 If @wenzhixin or you @djhvscf are aware of any other problems, or performance penalties let's summarize here. I suppose this could be a solution for many people if we resolve those two I found. NOTE: Rebase this work is fine for me, but if codebase changed a lot maybe we can start small and fix this working branch |
Hi Guys, I did it in a different way using filterby and adding a custom button. please check this out Let me know if you encounter issues |
Hello everyone! |
I'm not entirely sure what updates seem to have broken the previously-submitted workarounds, but, here's one I did today. It could use a little cleaning up (like the placeholder), but the idea is there. https://live.bootstrap-table.com/code/nickjrotundo/17769 Edit: typo and small cleanup |
Hello,
I was wondering if there is a way to get multiple select in filter-control to work? For example, selecting two (or more) filters in a single dropdown.
Thanks & kind regards.
The text was updated successfully, but these errors were encountered: