Extract the SimpleBuilder and add a MicrodataBuilder #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been included into a forked repo here: https://github.com/revans/breadcrumbs_on_rails/pull/1 |
ghost
assigned 
|
Hi @jlecour, Despite I like the idea and I believe you submitted a very good patch (given that you also attached a good test case), I'm not going to merge it. I'd like to keep the number of details builders as low as possible. However, I encourage you to package your builder as a separate gem. I can also link it from this library README if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've extracted the simple_builder in a separate file and added a microdata builder ; it makes a semantic breadcrumb.
Maybe you'll find this interesting.
Jeremy