Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into pr/443 (references GH-443)
- Loading branch information
Showing
35 changed files
with
764 additions
and
854 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
sudo: false | ||
language: ruby | ||
rvm: | ||
- 1.9.3 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Contributing | ||
|
||
We love pull requests from everyone. By participating in this project, you agree to abide by the contribution [code of conduct](http://contributor-covenant.org/version/1/2/0/). | ||
|
||
## Workflow | ||
|
||
Fork, then clone the repo: | ||
|
||
$ git clone git@github.com:your-username/whois.git | ||
|
||
Set up your machine: | ||
|
||
$ bundle | ||
|
||
Make sure the tests pass: | ||
|
||
$ bundle exec rake | ||
|
||
To propose a change/feature/patch, create your feature branch: | ||
|
||
$ git checkout -b my-new-feature | ||
|
||
Make your change. Add tests for your change. Make the tests pass: | ||
|
||
$ bundle exec rake | ||
|
||
Commit your changes: | ||
|
||
$ git commit -am 'Add some feature' | ||
|
||
Push to your fork and [submit a pull request](https://github.com/weppos/whois/compare/). | ||
|
||
|
||
## Tests | ||
|
||
To increase the chance that your pull request is accepted please **make sure to write tests**. Changes without corresponding tests will likely not be included as they will produce fragile code that can easily break whenever the registry changes the response format. | ||
|
||
Some examples: [84dbdde320f31c20184bcfe5e544e8fd3cd32862](https://github.com/weppos/whois/commit/84dbdde320f31c20184bcfe5e544e8fd3cd32862), [3b6688b95e6fadcf720cc777ef4bbd2cd644e62b](https://github.com/weppos/whois/commit/3b6688b95e6fadcf720cc777ef4bbd2cd644e62b) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
#!/usr/bin/env ruby -w | ||
#!/usr/bin/env ruby | ||
|
||
$:.unshift(File.expand_path("../../lib", __FILE__)) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Contributing | ||
|
||
We love pull requests from everyone. By participating in this project, you agree to abide by the contribution [code of conduct](http://contributor-covenant.org/version/1/2/0/). | ||
|
||
## Workflow | ||
|
||
Fork, then clone the repo: | ||
|
||
$ git clone git@github.com:your-username/whois.git | ||
|
||
Set up your machine: | ||
|
||
$ bundle | ||
|
||
Make sure the tests pass: | ||
|
||
$ bundle exec rake | ||
|
||
To propose a change/feature/patch, create your feature branch: | ||
|
||
$ git checkout -b my-new-feature | ||
|
||
Make your change. Add tests for your change. Make the tests pass: | ||
|
||
$ bundle exec rake | ||
|
||
Commit your changes: | ||
|
||
$ git commit -am 'Add some feature' | ||
|
||
Push to your fork and [submit a pull request](https://github.com/weppos/whois/compare/). | ||
|
||
|
||
## Tests | ||
|
||
To increase the chance that your pull request is accepted please **make sure to write tests**. Changes without corresponding tests will likely not be included as they will produce fragile code that can easily break whenever the registry changes the response format. |
Oops, something went wrong.