New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added features to whois.ua parser #169
Conversation
… for available domain in .ua parser
property_supported :created_on do | ||
if content_for_scanner =~ /created:\s+(.+)\n/ | ||
time = $1.split(" ").last | ||
begin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the case where the parsing fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:updated_on
and :expires_on
parse sections that existed before I've forked a repo, worked exactly the same. Should I do something special here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that originally there was an invalid date. This case doesn't seem to exist anymore so I would simply change the code to
time = $1.split(" ").last
Time.parse(time)
without the begin/rescue statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be done
Hi @Uko, the patch looks good to me. I only have a couple of requests
|
|
|
Looks like I've done everything you asked |
Added features to whois.ua parser
Merged, thank you! I just recommend you to change your editor settings to use spaces instead of tabs. Thanks again for your patch. |
Added
property_supported
:Added
property_not_supported
:Implemented
property
:Added one more test for registered domain.