Encapsulate definitions #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being able to access the entire definition Hash is something that is not going to be possible anymore. The library should be able to change the definitions without being afraid of breaking external implementations. Developers should not change the definitions directly, instead they should use #define to append new definitions. That also means that the definition order should not be relevant (GH-536). This patch changes the internal representation of the definitions, and hides them from the outside. It's not possible to access the definition list only using #definitions and passing the type. Different types may have different representations in the future. The returned list is always a clone, so that the internal definition list is not affected.
Instead of scanning each definition and using regular expressions, perform specific lookups for the parts that represent the domain. It also closes GH-536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to access the entire definition Hash is something that is
not going to be possible anymore.
The library should be able to change the definitions without being
afraid of breaking external implementations. Developers should not
change the definitions directly, instead they should use #define to
append new definitions. That also means that the definition order
should not be relevant (GH-536).
This patch changes the internal representation of the definitions, and
hides them from the outside. It's not possible to access the definition
list only using #definitions and passing the type. Different types may
have different representations in the future.
The returned list is always a clone, so that the internal definition
list is not affected.
Also closes GH-536