build(js): fix the same library being moved by nx using a patch #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary fix until nrwl/nx#16127 is merged and released
|
PR 903 with branch
|
Itrulia
commented
May 3, 2023
| @@ -12,7 +12,7 @@ | |||
| "@nrwl/nx/enforce-module-boundaries": [ | |||
| "error", | |||
| { | |||
| "enforceBuildableLibDependency": true, | |||
There was a problem hiding this comment.
with "external": "all", non buildable libraries can be dependent on
Itrulia
commented
May 3, 2023
| @@ -4,7 +4,8 @@ | |||
| "module": "commonjs", | |||
| "outDir": "../../dist/out-tsc", | |||
| "declaration": true, | |||
| "types": ["node"] | |||
| "types": ["node"], | |||
| "rootDirs": ["../../"] | |||
There was a problem hiding this comment.
Required so typescript can inline files below the rootDir
Itrulia
commented
May 3, 2023
| @@ -27,7 +27,9 @@ | |||
| "tsConfig": "libs/api/tsconfig.lib.json", | |||
| "packageJson": "libs/api/package.json", | |||
| "main": "libs/api/src/index.ts", | |||
| "assets": ["libs/api/*.md", "libs/api/prisma/**/*"] | |||
| "assets": ["libs/api/*.md", "libs/api/prisma/**/*"], | |||
| "external": "all", | |||
There was a problem hiding this comment.
Bundles all non publishable libraries
Itrulia
commented
May 3, 2023
| @@ -4,17 +4,6 @@ | |||
| "sourceRoot": "libs/authentication/api/src", | |||
| "projectType": "library", | |||
| "targets": { | |||
| "build": { | |||
There was a problem hiding this comment.
Not needed anymore. Is now built by api
Itrulia
commented
May 3, 2023
There was a problem hiding this comment.
Applied by the patch-package library. See PR description for explanation
tomaszdurka
approved these changes
May 3, 2023
penk85
approved these changes
May 8, 2023
Itrulia
added a commit
that referenced
this pull request
May 9, 2023
Temporary fix until nrwl/nx#16127 is merged and released
antkiewiczk
pushed a commit
that referenced
this pull request
May 9, 2023
Temporary fix until nrwl/nx#16127 is merged and released
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix until nrwl/nx#16127 is merged and released