Added additional arguments to script #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not much now, but adding OptionParser allows us to extend the code and add additional options later on. (which is the plan)
This allows you to set the GitHub description. (duh) Fixes issue wereHamster#4 wereHamster#4
Allows the user to change the name of the file (on the server, not locally) from the default value to something else.
This allows you to replace the file on the server if it already exists.
|
Thanks. The changes look good. But please keep the style consistent (2 space indentation etc.). |
|
Does that look good? (I was tempted to change all 2 space indentations to tabs, but I went by your preferences instead ;) |
It was already there, but I made it explicit in OptionParser to make it look nice when you run the help command.
A tiny typo.
|
👍 Thank you IQAndreas, I'm liking this addition... Enables many more possibilities. |
wereHamster
added a commit
that referenced
this pull request
Jul 3, 2012
Added additional arguments to script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes use the native OptionParser class to add additional arguments to the script which can be viewed with
github-upload.rb --help.