Use git command to create patches #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
distorhead
force-pushed
the
use-git-for-patch
branch
2 times, most recently
from
eb113ba
to
05da652
Compare
Go-git experiment failed for now. There is blocking issue to continue use go-git: * Corrupt patch generation for files without newline-at-the-end: src-d/go-git#936 And some non-blocking, but harmful: * Memory usage is too big on big repos: src-d/go-git#832 * Corrupt patch generation (solved in fork): src-d/go-git#932 Libgit2 is too complex to install or statically build into dapp. Also libgit2 has memory leaks. The decision is to use raw git command in a clean and efficient way. Implemented Diff operation.
* Use git-cli to create paches in dapp. * Refine GitRepo interface. * Apply binary patches support.
distorhead
force-pushed
the
use-git-for-patch
branch
from
05da652
to
80c1ce9
Compare
distorhead
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go-git experiment failed for now.
There is blocking issue to continue use go-git:
git applysrc-d/go-git#936And some non-blocking, but harmful:
fatal: corrupt patcherror in unified diff format src-d/go-git#932.Libgit2 is too complex to install or statically build into dapp. Also libgit2 has memory leaks.
The decision is to use raw git command in a clean and efficient way.