Handle pysnmp's RequestTimedOut
exception more appropriately
#17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Frederic,
thanks a stack for conceiving this fine program. We found that the code path when running into a
No SNMP response received before timeout
condition can be improved.While we don't quite like how the patch is currently implemented, the code now handles this condition well. In this case,
check_synology
will respond with state "UNKNOWN".With kind regards,
Andreas.
P.S.: For your reference, I am sharing two of the tracebacks we received below.
/cc @Tonkenfo