Improve evaluation of trigger state for "update status" mode #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Mar 12, 2022
amotl
force-pushed
the
fix-update-status
branch
from
36b84c0
to
249e11a
Compare
wernerfred
requested changes
Mar 12, 2022
amotl
force-pushed
the
fix-update-status
branch
from
2e0f7cf
to
e590114
Compare
amotl
commented
Mar 12, 2022
Comment on lines
-50
to
51
| | update | Shows the current DSM version and if DSM update is available | set w/c to any int this triggers: <br> warning if available and critical <br> if other than un-/available | | ||
| | update | Shows the current DSM version and if DSM update is available | if update is "Unavailable", will trigger OK <br> if update is "Available", will trigger WARNING <br> otherwise: UNKNOWN | | ||
| | status | Shows model, s/n, temp and status of system, fan, cpu fan and power supply | if temp higher than w/c in °C | |
There was a problem hiding this comment.
e590114 adjusts the README, as you suggested.
amotl
changed the title
wernerfred
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Frederic,
I believe this check to evaluate theCRITICALstatus for the "status update" sensor might never have worked. This patch fixes it.after reviewing the corresponding logic, it was considered to implement another proposal:
In this way, there will be no
CRITICALstate on this mode at all.With kind regards,
Andreas.