-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: ERROR ReferenceError: require is not defined #50
Comments
I guess I broke SSR now but please try 1.14.1 |
Thanks for the quick response. The original
The return value of |
dang it... I guess the fix has to be implemented in "kjua-svg".. |
Is another issue required for |
I guess. I'm the maintainer of that as well so in the end it doesn't make a difference.. I don't have time until next week though, PRs are highly appreciated if you have any idea how to fix this |
No problem at all since version |
@werthdavid I had the same error and saw that you weren't exporting the project as Angular recommends it. I decided to refactor it a little bit. I've updated the version to be v2.0.0 since it's kind of a big changes in your code. Hope this will help |
@werthdavid could you release a new version, now that the cod should be fixed? |
I'm on it. Currently testing it in one of my projects. I'll remove some unnecessary stuff and then make a release by the end of the day |
The end of the day came sooner than expected 😅 2.0.0 is out, let me know if you experience any problems |
@werthdavid I confirm that this does solve the issue, you may close this issue |
Unfortuately I still get the same TypeError with version |
Indeed, I don't know what I did test, sorry for my mistake. Then I do not understand the error... |
Hello, I'm also having the same TypeError and I'm using angular 13.2.2, "kjua-svg": "^1.13.1" and "ngx-kjua": "^2.0.0" |
hi ,Is it possible for me to run a compatible older version, ? |
You can run 1.13.2 |
Is this still the case with 2.0.1? |
This one is still appearing @werthdavid. I had to downgrade to 1.13.2
|
With 2.0.1
|
I also get the same error as @Sergiobop with version |
I can reproduce it... on it! |
I did play around with tsconfig but after a little research it seems to be a problem with ng-packagr... ng-packagr/ng-packagr#2215 |
just had exactly the same error: despite my package.json showed me 1.13.2 as ngx-kju (kju-svg: 1.13.1) - moved to a new workstation so maybe somehow it upgraded it upon installing all packages newly (and still showing old version). Upgraded it to 1.14.x to check but same error, downgraded back to 1.13.2 fixed it, all problems gone. BTW: the upper error is only showed in "dev mode" if I build my application it shows the "other" similar one: |
Is the bug fixed with this one @werthdavid @delyethan ? #60 If that's the case we can close this one and #53 (Also do a release?) BIG THANKS for your work! |
I fear as stated above the problem comes from ng-packagr... still waiting for a fix |
@hramberger Should be fixed, can you try it? |
I checked version 2.0.2 and it seems to work as expected again. Thanks for the fix! |
@werthdavid feel free to close that issue :) |
Description
After the update to
1.14.0
theNgxKjuaComponent
throws the following error when it is been initialized / first called in our application (see Stacktrace for more details):ERROR ReferenceError: require is not defined
The compilation on the other hand runs without any errors.
Moreover version
1.13.2
works fine in the exact same setting.Do I need a special configuration (e.g special compiler options) to make version
1.14.0
work?Stacktrace
The references in the stacktrace point to the following code in the transpiled
main.js
which is part of the class cunstructor ofNgxKjuaComponent
:Used versions
The text was updated successfully, but these errors were encountered: