Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging tags to most common spellings #637

Closed
maxpou opened this issue Feb 11, 2020 · 8 comments
Closed

Merging tags to most common spellings #637

maxpou opened this issue Feb 11, 2020 · 8 comments

Comments

@maxpou
Copy link
Contributor

maxpou commented Feb 11, 2020

hiya,

I just noticed that same filters have been repeated twice or more.

We have:

  • "Front End", "Front end" and "Frontend"
  • "Ruby On Rail", "Ruby on Rails" and "Rails" (rails === RoR right?)
  • "Gatsby" and "GatsbyJs"
  • "Vue" and "VueJS"

Do you mind if I merge people's tags to the most used?

@HugoDF
Copy link
Collaborator

HugoDF commented Feb 11, 2020

@maxpou go for it

There was an issue kicking around to deduplicate tags in the code but the agreed upon approach is to edit the data file.

Ideally, make 1 PR per tag that you're unifying.

maxpou added a commit to maxpou/awesome-uses that referenced this issue Feb 11, 2020
maxpou added a commit to maxpou/awesome-uses that referenced this issue Feb 11, 2020
maxpou added a commit to maxpou/awesome-uses that referenced this issue Feb 11, 2020
maxpou added a commit to maxpou/awesome-uses that referenced this issue Feb 11, 2020
@maxpou
Copy link
Contributor Author

maxpou commented Feb 11, 2020

@HugoDF there you go. As said before, I arbitrary took the most popular keyword

Someone can confirm this?

  • "Ruby On Rail", "Ruby on Rails" and "Rails" (rails === RoR right?)

@HugoDF
Copy link
Collaborator

HugoDF commented Feb 11, 2020

"Ruby On Rail", "Ruby on Rails" and "Rails" (rails === RoR right?)

This is correct, in this case I would use "Ruby on Rails"

gatarelib added a commit that referenced this issue Feb 19, 2020
gatarelib added a commit that referenced this issue Feb 19, 2020
@transiient transiient changed the title merging filter Merging tags to most common spellings Mar 1, 2020
@transiient
Copy link
Collaborator

We could list these common spellings at the top of data.js so people can easily reference them.

@nico-bachner
Copy link
Contributor

Hi,

I've been cleaning up some tags and realised that since it's actually really easy that this issue should perhaps be labelled "good for first-time" or similar.

Would a maintainer be so kind as to do this if they agree?
Cheers

wesbos added a commit that referenced this issue Oct 5, 2020
Merge duplicate Tailwind CSS tags (Issue #637)
wesbos added a commit that referenced this issue Oct 5, 2020
Merge duplicate Full Stack tags (Issue #637)
@nico-bachner
Copy link
Contributor

nico-bachner commented Oct 6, 2020

I'm planning on merging the VSCode tags next.

Which spelling is preferable: Visual Studio Code, VS Code or VSCode ?

wesbos added a commit that referenced this issue Oct 12, 2020
Merge duplicate DevOps tags(Issue #637)
wesbos added a commit that referenced this issue Oct 12, 2020
Merge duplicate Open Source Software tags (Issue #637)
wesbos added a commit that referenced this issue Oct 12, 2020
Merge duplicate JAMstack tags (Issue #637)
wesbos added a commit that referenced this issue Oct 12, 2020
Merge duplicate Front End tags (Issue #637)
wesbos added a commit that referenced this issue Oct 12, 2020
Merge duplicate Node.js tags (Issue #637)
BlakeCampbells added a commit that referenced this issue Dec 18, 2021
BlakeCampbells added a commit that referenced this issue Dec 18, 2021
BlakeCampbells added a commit that referenced this issue Dec 18, 2021
@carbontwelve
Copy link
Collaborator

I can see that this issue has a long history and @BlakeCampbells looks to have made progress in merging tags. Is this issue now completed, or is there work still to do?

@BlakeCampbells
Copy link
Collaborator

Good call @carbontwelve , I think this is okay to close.

To keep it from happening in the future we should add either some validation around tags or in src/util/stats.js we should make sure normalizeTags covers more cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants