Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roast FrontEnd Devs #194

Merged
merged 2 commits into from Feb 25, 2020
Merged

Roast FrontEnd Devs #194

merged 2 commits into from Feb 25, 2020

Conversation

abhidp
Copy link
Contributor

@abhidp abhidp commented Feb 14, 2020

Roast FrontEnd Devs

Roast FrontEnd Devs
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this joke can be changed from exclusion to inclusion

@abhidp
Copy link
Contributor Author

abhidp commented Feb 16, 2020

I think this joke can be changed from exclusion to inclusion

Ya, makes sense. But the inclusion is pretty straight forward and obvious and not as quirky as the exclusion.

For example, the inclusion : -

Q: Why don't C# developers wear glasses?
A: Because they can C# 

is not as funny as the exclusion : -

Q: Why do Java developers wear glasses?
A: Because they can't C#!

or

Q: Why do SQL Developers date one other?
A: Because they agree on relationships.

vs

Q: Why can't SQL and NoSQL Developers date one other?
A: Because they don't agree on relationships.

or like many other jokes in the thread.....

@styfle
Copy link
Collaborator

styfle commented Feb 16, 2020

Your PR Title says “Roast FrontEnd Devs” so it already implies that you intend to offend frontend developers.

Jokes don’t always need to be offensive. I think in this case it can be modified and still be funny.

@abhidp abhidp requested a review from wesbos February 17, 2020 03:42
@abhidp
Copy link
Contributor Author

abhidp commented Feb 17, 2020

Your PR Title says “Roast FrontEnd Devs” so it already implies that you intend to offend frontend developers.

Jokes don’t always need to be offensive. I think in this case it can be modified and still be funny.

I completely disagree on that (Period)

@wesbos
Copy link
Owner

wesbos commented Feb 21, 2020

this is fine - I don't see any bad intent and I think it's funny. can you add it to the bottom of the file though?

Moved joke to the bottom of the file
@abhidp
Copy link
Contributor Author

abhidp commented Feb 24, 2020

this is fine - I don't see any bad intent and I think it's funny. can you add it to the bottom of the file though?

@wesbos Done :)

@wesbos wesbos merged commit 398e371 into wesbos:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants