fix notification setting can't update without slack token #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fezzlk
commented
Apr 5, 2020
There was a problem hiding this comment.
管理画面の他の箇所に似たようなバグはなさそうですが、他のadmin container も同様にすべきでしょうか。
もしくは、ここを修正するのではなく、サーバー側のバリデーションのisString()を撤去するべきでしょうか
https://github.com/weseek/growi/blob/master/src/server/routes/apiv3/notification-setting.js#L19
| isNotificationForOwnerPageEnabled: notificationParams.isNotificationForOwnerPageEnabled, | ||
| isNotificationForGroupPageEnabled: notificationParams.isNotificationForGroupPageEnabled, | ||
| globalNotifications: notificationParams.globalNotifications, | ||
| webhookUrl: notificationParams.webhookUrl || '', |
There was a problem hiding this comment.
バグ解消のために必要なのは webhookUrl とslackToken だけですが念のため他も変更しました。
There was a problem hiding this comment.
apiV3/security-setting.js のように、
body('restrictGuestMode').if(value => value != null).isString().isIn([
'Deny', 'Readonly',
])
サーバー側の validation で 存在チェックを挟んでから型チェックをするのが良いと思います
added 2 commits
April 6, 2020 10:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.