Support/create link test #2430
Merged
Support/create link test #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
June 10, 2020 14:02
yuki-takei
requested changes
Jun 21, 2020
itizawa
commented
Jun 21, 2020
yuki-takei
requested changes
Jun 21, 2020
src/test/models/shareLink.test.js
Outdated
|
|
||
| test('share link is found, but it does not have Page', async() => { | ||
|
|
||
| shareLink.populate = jest.fn(() => { return { _id: 'somePageId' } }); |
There was a problem hiding this comment.
このテストの shareLink という変数名はちょっとピンとこないので、 findOneResult とかにした方がいいかな。
|
|
||
| const res = { | ||
| render: (page) => { return page }, | ||
| }; |
There was a problem hiding this comment.
うーん、改めて実装のコードを見たけどちょっと物足りないな。
この res は mock 化して、 res.render がちゃんと呼ばれたことを expect する
|
|
||
| expect(shareLink.populate).toHaveBeenCalled(); | ||
| expect(response).toEqual('layout-growi/shared_page'); | ||
| }); |
There was a problem hiding this comment.
return res.render(view, renderVars); が呼ばれ、かつ第二引数に値が入ることを expect しないといけない。
renderVars 生成部分をどの程度 mock 化するか、addRendarVarsForPage が呼ばれたかどうかまで確かめるかは気力次第(慣れるまでは結構大変だと思うので)
added 2 commits
June 22, 2020 19:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.