add default number to dropdown buttons #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaori-tokashiki
commented
Oct 16, 2020
Comment on lines
+157
to
+160
| pageLimitationS: await crowi.configManager.getConfig('crowi', 'customize:showPageLimitationS') || 20, | ||
| pageLimitationM: await crowi.configManager.getConfig('crowi', 'customize:showPageLimitationM') || 10, | ||
| pageLimitationL: await crowi.configManager.getConfig('crowi', 'customize:showPageLimitationL') || 50, | ||
| pageLimitationXL: await crowi.configManager.getConfig('crowi', 'customize:showPageLimitationXL') || 20, |
There was a problem hiding this comment.
DBにpageLimitationHogeがnullの場合、指定された数字が入るようにも設定しました。
yuki-takei
merged commit 764eb0c
into
feat/display-BookMarkList-including-pagination-as-component
yuki-takei
deleted the
imprv/gw4131-display-dropdown-label-in-case-of-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GW-4131 DB の値が null の場合、管理画面の設定値に値が表示されない
