Feat/gw 3826 setup uploader when update gcp config #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 16, 2020 15:45
…6-setup-uploader-when-update-gcp-config
fezzlk
changed the base branch from
feat/GW-3658-can-use-GCP-from-db-vars
to
master
fezzlk
changed the base branch from
master
to
feat/GW-3658-can-use-GCP-from-db-vars
fezzlk
changed the base branch from
feat/GW-3658-can-use-GCP-from-db-vars
to
master
fezzlk
changed the base branch from
master
to
feat/GW-3658-can-use-GCP-from-db-vars
added 2 commits
October 20, 2020 19:25
…6-setup-uploader-when-update-gcp-config
yuki-takei
requested changes
Oct 20, 2020
yuki-takei
approved these changes
Oct 20, 2020
|
|
||
| const method = envToModuleMappings[process.env.FILE_UPLOAD] || fileUplodeTypeInConfig || 'aws'; |
There was a problem hiding this comment.
後続タスクでいいんだけど、ここ綺麗にしたいなあ。
レガシーコードだから process.env の参照があっても許してたけど、本来は configManager.getConfig で参照した時には既に環境変数とDB値のどちらが強いのかは解決していてほしい。
yuki-takei
deleted the
feat/GW-3826-setup-uploader-when-update-gcp-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.