Feat/gw 4201 show message and fixed form in gcs settings #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fezzlk
commented
Oct 23, 2020
| @@ -535,7 +535,7 @@ | |||
| "missing mandatory configs": "The following mandatory items are not set in either database nor environment variables.", | |||
| "Local": { | |||
| "name": "ID/Password", | |||
| "note for the only env option": "The LOCAL authentication is limited by the value of environment variable.<br>To change this setting, please change to false or delete the value of the environment variable <code>{{env}}/code> .", | |||
| "note for the only env option": "The LOCAL authentication is limited by the value of environment variable.<br>To change this setting, please change to false or delete the value of the environment variable <code>{{env}}</code> .", | |||
| @@ -522,7 +522,7 @@ | |||
| "missing mandatory configs": "The following mandatory items are not set in either database nor environment variables.", | |||
| "Local": { | |||
| "name": "ID/Password", | |||
| "note for the only env option": "The LOCAL authentication is limited by the value of environment variable.<br>To change this setting, please change to false or delete the value of the environment variable <code>{{env}}/code> .", | |||
| "note for the only env option": "The LOCAL authentication is limited by the value of environment variable.<br>To change this setting, please change to false or delete the value of the environment variable <code>{{env}}</code> .", | |||
| </tbody> | ||
| </table> | ||
| <> | ||
| {gcsUseOnlyEnvVars && ( |
| dangerouslySetInnerHTML={{ __html: t('admin:app_setting.note_for_the_only_env_option', { env: 'IS_GCS_ENV_PRIORITIZED' }) }} | ||
| /> | ||
| )} | ||
| <table className={`table settings-table ${gcsUseOnlyEnvVars && 'use-only-env-vars'}`}> |
There was a problem hiding this comment.
以下三箇所のフォームに readOnly={gcsUseOnlyEnvVars} を追加しました
yuki-takei
deleted the
feat/gw-4201-show-message-and-fixed-form-in-gcs-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS_GCS_ENV_PRIORITIZEDが true の時に GCS 設定画面に info アラートを出すようにしました。(環境変数名は GW-4194で変更予定です)