imprv: Make updatedAt SWR #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaori-tokashiki
changed the title
kaori-tokashiki
changed the title
kaori-tokashiki
commented
Dec 20, 2021
| @@ -20,7 +20,7 @@ | |||
| data-page-created-at="{% if page %}{{ page.createdAt|datetz('Y/m/d H:i:s') }}{% endif %}" | |||
| data-page-creator="{% if page && page.creator %}{{ page.creator|json }}{% endif %}" | |||
| data-page-last-update-username="{% if page && page.lastUpdateUser %}{{ page.lastUpdateUser.name }}{% endif %}" | |||
| data-page-updated-at="{% if page %}{{ page.updatedAt|datetz('Y/m/d H:i:s') }}{% endif %}" | |||
There was a problem hiding this comment.
1行目に {% if page %}があるので、 この中ではif文必要ないと判断し削除しました。
kaori-tokashiki
commented
Dec 23, 2021
| @@ -60,7 +63,7 @@ const AuthorInfo = (props) => { | |||
| }; | |||
|
|
|||
| AuthorInfo.propTypes = { | |||
| date: PropTypes.string.isRequired, | |||
| date: PropTypes.instanceOf(Date), | |||
There was a problem hiding this comment.
undifinedが帰ってくる可能性があるのでisRequiredをつけていません
kaori-tokashiki
commented
Dec 23, 2021
Comment on lines
+19
to
+21
| const nullinfoLabelForFooter = mode === 'create' | ||
| ? 'Created by' | ||
| : 'Updated by'; |
There was a problem hiding this comment.
- nullの場合の表示です
yuki-takei
added
flag/exclude-from-changelog
and removed
flag/exclude-from-changelog
labels
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Note
View