Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 86631-cannot-reset-password-in-case-that-register-limitation-is-Closed #5155

Conversation

kaori-tokashiki
Copy link
Contributor

@kaori-tokashiki kaori-tokashiki commented Jan 24, 2022

Task

Issue

#5150

Cause

isRegistrationEnabled 変数のブロック内でForgot Passwordのリンクを貼り付けていたことにより、ID/Password設定の登録制限にて非公開(Closed)に設定している環境ではパスワードリセットのリンクが非表示になってしまっていました。

ScreenShots

Before

  • 登録制限が Open or Restrictedの時

Screen Shot 2022-01-24 at 19 37 41

  • 登録制限が Closedの時

Screen Shot 2022-01-24 at 19 38 56

After

  • 登録制限が Open or Restrictedの時

Screen Shot 2022-01-24 at 19 27 12

  • 登録制限が Closedの時

Screen Shot 2022-01-24 at 19 26 09

@kaori-tokashiki kaori-tokashiki changed the title get forgot-password-link outside fix: 86631-cannot-reset-password-in-case-that-register-limitation-is-Closed Jan 24, 2022
@kaori-tokashiki kaori-tokashiki temporarily deployed to VRT January 24, 2022 10:30 Inactive
@kaori-tokashiki kaori-tokashiki self-assigned this Jan 24, 2022
@kaori-tokashiki kaori-tokashiki temporarily deployed to VRT January 24, 2022 10:40 Inactive
@reg-suit
Copy link

reg-suit bot commented Jan 24, 2022

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit adb8106 into master Jan 24, 2022
@yuki-takei yuki-takei deleted the fix/86631-cannot-reset-password-in-case-that-register-limitation-is-Closed branch January 24, 2022 10:47
@github-actions github-actions bot mentioned this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Bug: Cannnot reset password in case that "Register limitation" is "Closed"
2 participants