Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chinese notation is broken on create new page modal #5973

Merged
merged 6 commits into from
Jun 7, 2022

Conversation

jam411
Copy link
Contributor

@jam411 jam411 commented Jun 3, 2022

https://redmine.weseek.co.jp/issues/96874

レビュー, 動作確認, コンフリクト解消行いました.
masterへマージ, タスク終了へお願いします.

@jam411 jam411 temporarily deployed to VRT June 3, 2022 09:06 Inactive
@jam411 jam411 self-assigned this Jun 6, 2022
@jam411 jam411 temporarily deployed to VRT June 7, 2022 02:07 Inactive
@@ -524,7 +524,7 @@
"template": {
"modal_label": {
"Create/Edit Template Page": "创建/编辑模板页",
"Create template under": "在下面创建模板页:<br/><code><small>%s</small></code>"
"Create template under": "在下面创建模板页:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すごい細かいんですけど、 って必要でしょうか??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日本語、英語ともにないのでいらないですね。ありがとうございます。

@jam411 jam411 temporarily deployed to VRT June 7, 2022 05:45 Inactive
@reg-suit
Copy link

reg-suit bot commented Jun 7, 2022

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@kaori-tokashiki kaori-tokashiki merged commit da18e97 into master Jun 7, 2022
@kaori-tokashiki kaori-tokashiki deleted the fix/96693-chinese-modal-text branch June 7, 2022 05:59
@github-actions github-actions bot mentioned this pull request Jun 7, 2022
@kaori-tokashiki kaori-tokashiki requested review from miya and removed request for miya June 7, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants