Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: Fix sidebar tag layout #5984

Merged
merged 11 commits into from
Jun 7, 2022
Merged

Conversation

jam411
Copy link
Contributor

@jam411 jam411 commented Jun 6, 2022

https://redmine.weseek.co.jp/issues/96618

<主な変更点>
・タグリストとタグクラウドの位置の入れ替え.
・タグクラウドには上位20位のタグが表示される. react-tagcloudの廃止. タグデザインは他と統一.
・その他マージンやフォントなど調整し, デザインチェック済み.

@jam411 jam411 changed the title Imprv: Fix sidebar tag layout imprv: Fix sidebar tag layout Jun 6, 2022
@jam411 jam411 temporarily deployed to VRT June 6, 2022 11:03 Inactive
@jam411 jam411 temporarily deployed to VRT June 7, 2022 06:04 Inactive
@reg-suit
Copy link

reg-suit bot commented Jun 7, 2022

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@jam411 jam411 requested a review from miya June 7, 2022 06:16
@jam411 jam411 self-assigned this Jun 7, 2022
@yuki-takei yuki-takei merged commit 75d2850 into master Jun 7, 2022
@yuki-takei yuki-takei deleted the imprv/94973-fix-sidebartag-layout branch June 7, 2022 06:36
@github-actions github-actions bot mentioned this pull request Jun 7, 2022
@jam411 jam411 requested review from yuki-takei and removed request for miya June 7, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants