imprv: Do not use api for fetching pages when using shared pages #7213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
commented
Jan 5, 2023
yuki-takei
requested changes
Jan 5, 2023
packages/app/src/components/Navbar/GrowiContextualSubNavigation.tsx
Outdated
Show resolved
Hide resolved
miya
commented
Jan 6, 2023
yuki-takei
requested changes
Jan 6, 2023
yuki-takei
approved these changes
Jan 6, 2023
| : { | ||
| fetcher: () => null, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
useShareLinkId 復活、設定時は config 値を渡して fetcher を上書きする
| @@ -42,6 +44,7 @@ export const useSWRxPage = ( | |||
| } | |||
| throw Error('failed to get page'); | |||
| }), | |||
| config, | |||
There was a problem hiding this comment.
config に fetcher を入れていれば上書きできるが、そもそも自動 fetch を無効にしたいわけなので、SWR@v2 にアップグレードしたら useSWRMutation を使うのがよさそう
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
yuki-takei
deleted the
imprv/112501-do-not-use-api-for-fetching-pages-when-using-shared-pages
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
#112499 [Next.js] SharedPage で /_page/v3/page を叩かないようにする
└ #112501 改善