Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attach i18n User Setting and TagEditModal #7216

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Conversation

jam411
Copy link
Contributor

@jam411 jam411 commented Jan 6, 2023

task:
https://redmine.weseek.co.jp/issues/112578
https://redmine.weseek.co.jp/issues/112579

Screenshot

User Setting

image

  • 英語と中国語はもともと用意されていたので対処不要

TagEditModal

  • 日本語
    image

  • 中国語
    image

@jam411 jam411 self-assigned this Jan 6, 2023
@jam411 jam411 requested a review from yuki-takei January 6, 2023 07:37
@jam411 jam411 temporarily deployed to VRT January 6, 2023 07:55 — with GitHub Actions Inactive
@jam411 jam411 temporarily deployed to VRT January 6, 2023 08:14 — with GitHub Actions Inactive
@reg-suit
Copy link

reg-suit bot commented Jan 6, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴
⚪⚪

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit 348789e into master Jan 6, 2023
@yuki-takei yuki-takei deleted the fix/attach-i18n branch January 6, 2023 09:01
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants