Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: Allow registering without GROWI email settings for ID/Password authentication's restricted registration #7591

Merged

Conversation

jam411
Copy link
Contributor

@jam411 jam411 commented Apr 21, 2023

登録の制限 関連の統合ブランチのマスターマージ

後続タスク

note

登録の制限(非公開) の招待機能は、現状バージョンでも、メール設定なしでも登録可能(管理者が invite 状態のユーザを作成できる)だった。
image

ryoji-s and others added 24 commits April 11, 2023 08:20
…cation' into imprv/119788-119796-delete-id-password-mail-setting-alert
…cation' into imprv/119788-119796-delete-id-password-mail-setting-alert
…cation' into imprv/119788-119796-delete-id-password-mail-setting-alert
…ssword-mail-setting-alert

imprv: Update `please_enable_mailer` alert position on LocalSecuritySettingContents
…cation' into imprv/119788-120045-can-use-sing-up-registration-setting-without-mail-setting
…cation' into imprv/119788-120045-can-use-sing-up-registration-setting-without-mail-setting
…-up-registration-setting-without-mail-setting

imprv: Can use registration approval request without mail settings
@jam411 jam411 requested a review from yuki-takei April 21, 2023 03:02
@jam411 jam411 self-assigned this Apr 21, 2023
@jam411 jam411 changed the title imprv: 119788 mail setting and id password login specification imprv: Allow registering without GROWI email settings for ID/Password authentication's restricted registration Apr 21, 2023
@jam411 jam411 temporarily deployed to VRT April 21, 2023 03:21 — with GitHub Actions Inactive
@reg-suit
Copy link

reg-suit bot commented Apr 21, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit 5bdfbd5 into master Apr 21, 2023
28 checks passed
@yuki-takei yuki-takei deleted the imprv/119788-mail-setting-and-id-password-login-specification branch April 21, 2023 11:30
@github-actions github-actions bot mentioned this pull request Apr 21, 2023
@yuki-takei yuki-takei mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants