fix: Editor not resetting when the same markdown #7625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arafubeatbox
commented
May 6, 2023
| if (currentPagePath != null) { | ||
| editorRef.current?.setValue(initialValue); | ||
| } | ||
| }, [currentPagePath, initialValue]); |
There was a problem hiding this comment.
ページが変更されても CodeMirror に行き渡る initialValue が同じだと CodeMirror のコード値は変わらないので、明示的に初期値に更新
arafubeatbox
commented
May 6, 2023
| @@ -571,7 +571,7 @@ class CodeMirrorEditor extends AbstractEditor { | |||
|
|
|||
| changeHandler(editor, data, value) { | |||
| if (this.props.onChange != null) { | |||
| const isClean = data.origin == null || editor.isClean(); | |||
| const isClean = data.origin == null || editor.isClean() || value === this.props.value; | |||
There was a problem hiding this comment.
値が同じままの際は clean とする。
（今回の実装で isEnabledUnsavedWarning が true とならないように追記）
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
jam411
approved these changes
May 9, 2023
|
プロダクションビルドで動作確認し期待通りでした。 |
yuki-takei
changed the title
yuki-takei
deleted the
fix/115285-116132-editor-not-resetting-when-same-markdown
branch
Merged
Merged
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review task
https://redmine.weseek.co.jp/issues/121597