fix: Initialize grant correctly after when page transition #8633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukendev
commented
Mar 29, 2024
yukendev
commented
Mar 29, 2024
| @@ -129,6 +132,8 @@ export const useUpdateStateAfterSave = (pageId: string|undefined|null, opts?: Up | |||
| mutateEditingMarkdown(updatedPage.revision.body); | |||
| } | |||
|
|
|||
| await mutateGrant(); | |||
There was a problem hiding this comment.
ページ保存時にgrantデータがmutateされておらず、ページ移動しても初期化時に入れたgrantデータが保持されたままだったことが不具合の原因だったので、ページ保存時にgrantデータをmutateするようにしました
There was a problem hiding this comment.
useSWRxApplicableGrant も同様の理屈で mutate する必要があるんじゃないかな
There was a problem hiding this comment.
その必要がありそうだったので追加しました。
yuki-takei
changed the title
yuki-takei
requested changes
Mar 29, 2024
| @@ -129,6 +132,8 @@ export const useUpdateStateAfterSave = (pageId: string|undefined|null, opts?: Up | |||
| mutateEditingMarkdown(updatedPage.revision.body); | |||
| } | |||
|
|
|||
| await mutateGrant(); | |||
There was a problem hiding this comment.
useSWRxApplicableGrant も同様の理屈で mutate する必要があるんじゃないかな
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ストーリー: https://redmine.weseek.co.jp/issues/140819
タスク: https://redmine.weseek.co.jp/issues/143352
やったこと
ページ編集の保存時に、
useSWRxIsGrantNormalizedのmutateを行うようにした