imprv: behavior of dropdown toggle in 'Recent Changes' sidebar #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maeshinshin
changed the title
yuki-takei
requested changes
May 2, 2024
| else { | ||
| setDropdownOpen(prevState => !prevState); | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
react 的プログラムではなく pure js っぽい解になってしまっている
There was a problem hiding this comment.
以下をもとに、reactstrap ではなく、react bootstrap を利用した実装に変更しました。
https://getbootstrap.jp/docs/5.3/components/dropdowns/#%e8%87%aa%e5%8b%95%e3%81%a7%e9%96%89%e3%81%98%e3%82%8b
| @@ -182,12 +192,12 @@ export const RecentChangesHeader = ({ | |||
| <> | |||
| <SidebarHeaderReloadButton onClick={() => mutate()} /> | |||
|
|
|||
| <UncontrolledButtonDropdown className="me-1"> | |||
| <UncontrolledButtonDropdown className="me-1" isOpen={dropdownOpen} toggle={handleDropdownToggle}> | |||
There was a problem hiding this comment.
isOpen を制御するのなら Uncontrolled ではないコンポーネントを使うべきなのでは？)
maeshinshin
force-pushed
the
imprv/141636-145347-sidebar-recent-changes-dropdown-toggle
branch
from
0cfca97
to
e4d7d87
Compare
…n in RecentChangesSubstance.tsx
maeshinshin
force-pushed
the
imprv/141636-145347-sidebar-recent-changes-dropdown-toggle
branch
from
e4d7d87
to
22c1244
Compare
miya
reviewed
May 8, 2024
| <UncontrolledButtonDropdown className="me-1"> | ||
| <DropdownToggle color="transparent" className="p-0 border-0"> | ||
| <div className="me-1"> | ||
| <Button |
There was a problem hiding this comment.
これはあえて reactstrap 由来のコンポーネントを使っている？
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
yuki-takei
deleted the
imprv/141636-145347-sidebar-recent-changes-dropdown-toggle
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
#141636: サイドバー「最新の変更」の三点リーダー内ドロップダウンのトグル押下後の挙動の修正
┗ #145347 実装
Demo