Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Docker image & deployment #180

Closed
10 tasks done
kleisauke opened this issue Apr 28, 2019 · 3 comments
Closed
10 tasks done

Improve Docker image & deployment #180

kleisauke opened this issue Apr 28, 2019 · 3 comments

Comments

@kleisauke
Copy link
Member

@kleisauke kleisauke commented Apr 28, 2019

Things that should be done, in no order:

  • Create an organization on Docker Hub.
    Done: https://hub.docker.com/u/weserv.
  • Copy the contents of this repository to the container instead of defining /var/www/imagesweserv as volume.
    • Perhaps we could just clone the repo (?). For example:
    RUN git clone https://github.com/weserv/images.git /var/www/imagesweserv
    
  • Copy /config/nginx/conf.d to /usr/local/openresty/nginx/conf/conf.d/ instead of defining that directory as volume.
  • Add RUN make dev to the Dockerfile to install the required LuaRocks dependencies.
  • Remove the heavy-weight supervisord approach and set the Docker entrypoint to:
    ENTRYPOINT ["nginx", "-g", "daemon off;"]
    
    • This implies that Redis rate limiter is disabled in the Docker file. Is this the right solution?
  • Should we remove /dev/shm as a volume?
  • Publish the revamped Docker image to GitHub's Container Registry.
  • Test the image on the Google Cloud Platform. See: #179.

If someone knows more tasks, please feel free to add them in the comments.

@andrieslouw
Copy link
Member

@andrieslouw andrieslouw commented May 28, 2019

  • Double-check if the Docker image works out-of-the-box, see #182 .

Loading

@andrieslouw
Copy link
Member

@andrieslouw andrieslouw commented Dec 16, 2019

#204 is part of the work on the Docker deployment.

Loading

@kleisauke
Copy link
Member Author

@kleisauke kleisauke commented Nov 21, 2021

I know a number of people running the Docker image on Google Cloud Platform without any issues, I'll close.

Loading

@kleisauke kleisauke closed this Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants