Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Docker image & deployment #180

Open
kleisauke opened this issue Apr 28, 2019 · 1 comment

Comments

@kleisauke
Copy link
Member

commented Apr 28, 2019

Things that should be done, in no order:

  • Create an organization on Docker Hub.
    Done: https://hub.docker.com/u/weserv.
  • Copy the contents of this repository to the container instead of defining /var/www/imagesweserv as volume.
    • Perhaps we could just clone the repo (?). For example:
    RUN git clone https://github.com/weserv/images.git /var/www/imagesweserv
    
  • Copy /config/nginx/conf.d to /usr/local/openresty/nginx/conf/conf.d/ instead of defining that directory as volume.
  • Add RUN make dev to the Dockerfile to install the required LuaRocks dependencies.
  • Remove the heavy-weight supervisord approach and set the Docker entrypoint to:
    ENTRYPOINT ["nginx", "-g", "daemon off;"]
    
    • This implies that Redis rate limiter is disabled in the Docker file. Is this the right solution?
  • Should we remove /dev/shm as a volume?
  • Publish the revamped Docker image to Docker Hub.
  • Test the image on the Google Cloud Platform. See: #179.

If someone knows more tasks, please feel free to add them in the comments.

@andrieslouw

This comment has been minimized.

Copy link
Member

commented May 28, 2019

  • Double-check if the Docker image works out-of-the-box, see #182 .
kleisauke added a commit that referenced this issue May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.