Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to compare files with different names while comparing directories #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Oct 17, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This PR adds a new feature to the Meld tool that allows comparing files or directories with different names while comparing directories. This feature enhances the flexibility of the directory comparison functionality.

Summary of Changes

  • Added a new method select_left_file_to_compare in the DirDiff class to store the selected file or directory path on the left side.
  • Added a new method select_right_file_to_compare in the DirDiff class to store the selected file or directory path on the right side.
  • Modified the on_button_press_event method in the DirDiff class to add two new options in the context menu: "Select left file/dir to compare" and "Compare to 'filename'". These options allow the user to select the left file or directory to compare and the right file or directory with a different name to compare.
  • Modified the compare_selected_files method in the DirDiff class to compare the files or directories stored in the class variables when the "Compare to 'filename'" option is selected.

Please review and merge this PR to incorporate the requested feature.

Fixes #2.


🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai
Copy link
Author

sweep-ai bot commented Oct 17, 2023

Rollback Files For Sweep

  • Rollback changes to meld/dirdiff.py

@sweep-ai
Copy link
Author

sweep-ai bot commented Oct 17, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
0 participants