-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/aws integration #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Manjish Let remove this cognito and upload file implementation. Adding up only and services is ok 🙏🏾
domain/user/module.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Manjish Let's remove this as auto migrate invocation and stick to writing migration for schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be fixed by #114
domain/user/repository.go
Outdated
// For AutoMigrating (used in fx.Invoke) | ||
func Migrate(r Repository) error { | ||
r.logger.Info("[Migrating...User]") | ||
if err := r.DB.AutoMigrate(&models.User{}); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let revert these changes ! @Manjish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be fixed by #114
Please merge #114 before merging this PR |
…s-integration Refactor/enhancement in AWS integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
API Information
/api/upload-test
/api/send-test-email