Improvement in layout, IE7 fix, and collapsed sub-trees #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les to get mis-aligned. Every sub-tree pushed things off by one pixel. With a deep tree, you end up with lines not meeting nodes. This fixes it.
…ing space inside the relevant TD elements. Still works fine on Safari, Chrome, IE8&9, Firefox, and Camino
|
Great work Neil :) A few small tweaks have added a lot of value. Someone just poked me about the IE7 thing an hour ago! |
wesnolte
added a commit
that referenced
this pull request
Jan 19, 2012
Improvement in layout, IE7 fix, and collapsed sub-trees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Wes,
Thanks for your OrgChart plugin. I was working on something very similar, but you're further along than me!
I've made three changes:
[1]
Side padding for nodes meant that with deep trees, as you expanded/closed sub-trees, things would move a little. This also meant that on some older browsers the lines wouldn't align with nodes. Now renders cleanly on IE 7/8/9, Chrome, Firefox, Safari, Opera and Camino.
[2]
On IE7 the horizontal lines weren't showing up. The fix was just to put an inside the relevant TD elements.
[3]
Added the ability to start off with parts of the tree collapsed. Just add class=collapsed to the relevant LI element.
cheers,
Neil