Skip to content

Commit

Permalink
wmllint: Add check for [theme]s without an id
Browse files Browse the repository at this point in the history
  • Loading branch information
irydacea committed Feb 20, 2014
1 parent e2bc4a9 commit 16677d0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions data/tools/wmllint
Expand Up @@ -612,6 +612,8 @@ def validate_on_pop(tagstack, closer, filename, lineno):
if closer == "theme" and "id" not in attributes:
if "name" in attributes:
print '"%s", line %d: using [theme]name= instead of [theme]id= is deprecated' % (filename, lineno)
else:
print '"%s", line %d: [theme] needs an id attribute' % (filename, lineno)
# Check for user-visible themes that lack a UI name or description.
if closer == "theme" and ("hidden" not in attributes or attributes["hidden"] not in ("yes", "true")):
for attr in ("name", "description"):
Expand Down

0 comments on commit 16677d0

Please sign in to comment.