Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user can invoke actions during a unsycned event. #2021

Closed
gfgtdf opened this issue Sep 20, 2017 · 2 comments
Closed

user can invoke actions during a unsycned event. #2021

gfgtdf opened this issue Sep 20, 2017 · 2 comments
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Ready for testing Issues for which a potential fix is available but untested. UI User interface issues, including both back-end and front-end issues. WML Issues involving the WML engine or WML APIs.
Milestone
1.13.9

Comments

@gfgtdf
Copy link
Contributor

gfgtdf commented Sep 20, 2017

while investigating issue #2018 ob observed a bug: Assume this code:

	[event]
		name = "start"
		[set_menu_item]
			synced=no
			id = "menu_1"
			description = "menu 1"
			[command]
				[message]
					speaker="narrator"
					message="before"
				[/message]
				[delay]
					time=10000
				[/delay]
				[message]
					speaker="narrator"
					message="after"
				[/message]
			[/command]
		[/set_menu_item]
	[/event]

during the 10 second where the [delay] Is executed th user can issue other commands like attacking, recruiting or moving units.

Since thi can easiyl be worked around by not issing these command during auch a menu hander or by not using delay in these type of mennu item i don't think this blocks the 1.13.9 release, but it is something that must be fixed before 1.14
@gfgtdf gfgtdf added Blocker: New Stable Issues that must be resolved prior to the next stable series being released. UI User interface issues, including both back-end and front-end issues. WML Issues involving the WML engine or WML APIs. labels Sep 20, 2017
@gfgtdf gfgtdf added this to the 1.14.0 milestone Sep 20, 2017
@gfgtdf gfgtdf closed this as completed in 6a05911 Sep 20, 2017
@gfgtdf
Copy link
Contributor Author

gfgtdf commented Sep 20, 2017

i'll repoen this so that i don't forget to test my commit

@gfgtdf gfgtdf reopened this Sep 20, 2017
@gfgtdf gfgtdf added the Ready for testing Issues for which a potential fix is available but untested. label Sep 20, 2017
@gfgtdf gfgtdf changed the title user can onvoke actons during a unsycned event. user can invoke actons during a unsycned event. Sep 20, 2017
@gfgtdf gfgtdf changed the title user can invoke actons during a unsycned event. user can invoke actions during a unsycned event. Sep 20, 2017
@gfgtdf gfgtdf modified the milestones: 1.14.0, 1.14.1, 1.13.9 Sep 22, 2017
@gfgtdf
Copy link
Contributor Author

gfgtdf commented Sep 23, 2017

confirmed to be fixed in 1.13.10

@gfgtdf gfgtdf closed this as completed Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker: New Stable Issues that must be resolved prior to the next stable series being released. Ready for testing Issues for which a potential fix is available but untested. UI User interface issues, including both back-end and front-end issues. WML Issues involving the WML engine or WML APIs.
Projects
None yet
Milestone
1.13.9
Development

No branches or pull requests
1 participant
@gfgtdf